Pass tool manifest path on to cargo metadata command#156
Merged
burrbull merged 2 commits intoApr 20, 2025
Conversation
Emilgardis
previously approved these changes
Apr 20, 2025
Member
Emilgardis
left a comment
Emilgardis
left a comment
There was a problem hiding this comment.
Thank you! Could you add an entry to the changelog please :)
burrbull
approved these changes
Apr 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to fix an issue with running
cargo objcopy(and likely other binutils) outside of a project directory. For example, when I runcargo objcopyoutside of a project directory, I get the following error:Passing the
manifest-pathalong to theMetadataCommandfixes this, and seems to align the behavior of binutils withcargo build.